wonderful-mobile/exynos-linux-stable
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
exynos-linux-stable/drivers/acpi/apei
History
Takashi Iwai 54c74d3881 ACPI: APEI / ERST: Fix missing error handling in erst_reader() 
commit bb82e0b4a7e96494f0c1004ce50cec3d7b5fb3d1 upstream.

The commit f6f8285132 ("pstore: pass allocated memory region back to
caller") changed the check of the return value from erst_read() in
erst_reader() in the following way:

        if (len == -ENOENT)
                goto skip;
-       else if (len < 0) {
-               rc = -1;
+       else if (len < sizeof(*rcd)) {
+               rc = -EIO;
                goto out;

This introduced another bug: since the comparison with sizeof() is
cast to unsigned, a negative len value doesn't hit any longer.
As a result, when an error is returned from erst_read(), the code
falls through, and it may eventually lead to some weird thing like
memory corruption.

This patch adds the negative error value check more explicitly for
addressing the issue.

Fixes: f6f8285132 (pstore: pass allocated memory region back to caller)
Tested-by: Jerry Tang <jtang@suse.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-12-29 17:42:57 +01:00
..
apei-base.c ACPI / APEI: Fix leaked resources 2016-03-11 00:13:25 +01:00
apei-internal.h ACPI / APEI: Add Boot Error Record Table (BERT) support 2016-06-29 23:35:05 +02:00
bert.c ACPI / APEI: Add Boot Error Record Table (BERT) support 2016-06-29 23:35:05 +02:00
einj.c ACPI / einj: Make error paths more talkative 2016-06-23 23:41:38 +02:00
erst-dbg.c ACPI: Remove FSF mailing addresses 2015-07-08 02:27:32 +02:00
erst.c ACPI: APEI / ERST: Fix missing error handling in erst_reader() 2017-12-29 17:42:57 +01:00
ghes.c ACPI / APEI: Add missing synchronize_rcu() on NOTIFY_SCI removal 2017-08-30 10:21:56 +02:00
hest.c ACPI: Remove FSF mailing addresses 2015-07-08 02:27:32 +02:00
Kconfig acpi, apei, ghes: Make NMI error notification to be GHES architecture extension. 2014-07-22 15:05:06 -07:00
Makefile ACPI / APEI: Add Boot Error Record Table (BERT) support 2016-06-29 23:35:05 +02:00