mm: remove nr_pages argument from pagevec_lookup_{,range}_tag()
All users of pagevec_lookup() and pagevec_lookup_range() now pass PAGEVEC_SIZE as a desired number of pages. Just drop the argument. Link: http://lkml.kernel.org/r/20171009151359.31984-15-jack@suse.cz Signed-off-by: Jan Kara <jack@suse.cz> Reviewed-by: Daniel Jordan <daniel.m.jordan@oracle.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> (cherry picked from commit 20991f2990f8ff6f7de0443bb1a5683972d42005) (cherry picked from commit 86b079991424d607cbdf407ea26448b6ddbd0279)
This commit is contained in:
parent
b187cfe0cf
commit
566522c8d3
12 changed files with 35 additions and 38 deletions
|
@ -3830,8 +3830,8 @@ retry:
|
|||
if (wbc->sync_mode == WB_SYNC_ALL)
|
||||
tag_pages_for_writeback(mapping, index, end);
|
||||
while (!done && !nr_to_write_done && (index <= end) &&
|
||||
(nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, tag,
|
||||
min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1))) {
|
||||
(nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index, end,
|
||||
tag))) {
|
||||
unsigned i;
|
||||
|
||||
scanned = 1;
|
||||
|
@ -3978,8 +3978,8 @@ retry:
|
|||
tag_pages_for_writeback(mapping, index, end);
|
||||
done_index = index;
|
||||
while (!done && !nr_to_write_done && (index <= end) &&
|
||||
(nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, tag,
|
||||
min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1))) {
|
||||
(nr_pages = pagevec_lookup_range_tag(&pvec, mapping,
|
||||
&index, end, tag))) {
|
||||
unsigned i;
|
||||
|
||||
scanned = 1;
|
||||
|
|
|
@ -849,10 +849,9 @@ get_more_pages:
|
|||
min((pgoff_t)PAGEVEC_SIZE,
|
||||
max_pages - (pgoff_t)locked_pages) - 1)
|
||||
+ 1;
|
||||
pvec_pages = pagevec_lookup_tag(&pvec, mapping, &index,
|
||||
PAGECACHE_TAG_DIRTY,
|
||||
want);
|
||||
dout("pagevec_lookup_tag got %d\n", pvec_pages);
|
||||
pvec_pages = pagevec_lookup_range_tag(&pvec, mapping, &index,
|
||||
end, PAGECACHE_TAG_DIRTY);
|
||||
dout("pagevec_lookup_range_tag got %d\n", pvec_pages);
|
||||
if (!pvec_pages && !locked_pages)
|
||||
break;
|
||||
for (i = 0; i < pvec_pages && locked_pages < max_pages; i++) {
|
||||
|
|
|
@ -2586,8 +2586,8 @@ static int mpage_prepare_extent_to_map(struct mpage_da_data *mpd)
|
|||
mpd->map.m_len = 0;
|
||||
mpd->next_page = index;
|
||||
while (index <= end) {
|
||||
nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, tag,
|
||||
min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1);
|
||||
nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index, end,
|
||||
tag);
|
||||
if (nr_pages == 0)
|
||||
goto out;
|
||||
|
||||
|
|
|
@ -1769,8 +1769,8 @@ int f2fs_sync_node_pages(struct f2fs_sb_info *sbi,
|
|||
next_step:
|
||||
index = 0;
|
||||
|
||||
while (!done && (nr_pages = pagevec_lookup_tag(&pvec,
|
||||
NODE_MAPPING(sbi), &index, PAGECACHE_TAG_DIRTY))) {
|
||||
while ((nr_pages = pagevec_lookup_tag(&pvec, NODE_MAPPING(sbi), &index,
|
||||
PAGECACHE_TAG_DIRTY))) {
|
||||
int i;
|
||||
|
||||
for (i = 0; i < nr_pages; i++) {
|
||||
|
|
|
@ -401,8 +401,8 @@ retry:
|
|||
tag_pages_for_writeback(mapping, index, end);
|
||||
done_index = index;
|
||||
while (!done && (index <= end)) {
|
||||
nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, tag,
|
||||
min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1);
|
||||
nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index, end,
|
||||
tag);
|
||||
if (nr_pages == 0)
|
||||
break;
|
||||
|
||||
|
|
|
@ -2158,8 +2158,8 @@ static void nilfs_btree_lookup_dirty_buffers(struct nilfs_bmap *btree,
|
|||
|
||||
pagevec_init(&pvec, 0);
|
||||
|
||||
while (pagevec_lookup_tag(&pvec, btcache, &index, PAGECACHE_TAG_DIRTY,
|
||||
PAGEVEC_SIZE)) {
|
||||
while (pagevec_lookup_tag(&pvec, btcache, &index,
|
||||
PAGECACHE_TAG_DIRTY)) {
|
||||
for (i = 0; i < pagevec_count(&pvec); i++) {
|
||||
bh = head = page_buffers(pvec.pages[i]);
|
||||
do {
|
||||
|
|
|
@ -257,8 +257,7 @@ int nilfs_copy_dirty_pages(struct address_space *dmap,
|
|||
|
||||
pagevec_init(&pvec, 0);
|
||||
repeat:
|
||||
if (!pagevec_lookup_tag(&pvec, smap, &index, PAGECACHE_TAG_DIRTY,
|
||||
PAGEVEC_SIZE))
|
||||
if (!pagevec_lookup_tag(&pvec, smap, &index, PAGECACHE_TAG_DIRTY))
|
||||
return 0;
|
||||
|
||||
for (i = 0; i < pagevec_count(&pvec); i++) {
|
||||
|
@ -377,8 +376,8 @@ void nilfs_clear_dirty_pages(struct address_space *mapping, bool silent)
|
|||
|
||||
pagevec_init(&pvec, 0);
|
||||
|
||||
while (pagevec_lookup_tag(&pvec, mapping, &index, PAGECACHE_TAG_DIRTY,
|
||||
PAGEVEC_SIZE)) {
|
||||
while (pagevec_lookup_tag(&pvec, mapping, &index,
|
||||
PAGECACHE_TAG_DIRTY)) {
|
||||
for (i = 0; i < pagevec_count(&pvec); i++) {
|
||||
struct page *page = pvec.pages[i];
|
||||
|
||||
|
|
|
@ -709,9 +709,8 @@ static size_t nilfs_lookup_dirty_data_buffers(struct inode *inode,
|
|||
pagevec_init(&pvec, 0);
|
||||
repeat:
|
||||
if (unlikely(index > last) ||
|
||||
!pagevec_lookup_tag(&pvec, mapping, &index, PAGECACHE_TAG_DIRTY,
|
||||
min_t(pgoff_t, last - index,
|
||||
PAGEVEC_SIZE - 1) + 1))
|
||||
!pagevec_lookup_range_tag(&pvec, mapping, &index, last,
|
||||
PAGECACHE_TAG_DIRTY))
|
||||
return ndirties;
|
||||
|
||||
for (i = 0; i < pagevec_count(&pvec); i++) {
|
||||
|
@ -757,8 +756,8 @@ static void nilfs_lookup_dirty_node_buffers(struct inode *inode,
|
|||
|
||||
pagevec_init(&pvec, 0);
|
||||
|
||||
while (pagevec_lookup_tag(&pvec, mapping, &index, PAGECACHE_TAG_DIRTY,
|
||||
PAGEVEC_SIZE)) {
|
||||
while (pagevec_lookup_tag(&pvec, mapping, &index,
|
||||
PAGECACHE_TAG_DIRTY)) {
|
||||
for (i = 0; i < pagevec_count(&pvec); i++) {
|
||||
bh = head = page_buffers(pvec.pages[i]);
|
||||
do {
|
||||
|
|
|
@ -31,16 +31,14 @@ unsigned pagevec_lookup(struct pagevec *pvec, struct address_space *mapping,
|
|||
pgoff_t start, unsigned nr_pages);
|
||||
unsigned pagevec_lookup_range_tag(struct pagevec *pvec,
|
||||
struct address_space *mapping, pgoff_t *index, pgoff_t end,
|
||||
int tag, unsigned nr_pages);
|
||||
int tag);
|
||||
unsigned pagevec_lookup_range_nr_tag(struct pagevec *pvec,
|
||||
struct address_space *mapping, pgoff_t *index, pgoff_t end,
|
||||
int tag, unsigned max_pages);
|
||||
static inline unsigned pagevec_lookup_tag(struct pagevec *pvec,
|
||||
struct address_space *mapping, pgoff_t *index, int tag,
|
||||
unsigned nr_pages)
|
||||
struct address_space *mapping, pgoff_t *index, int tag)
|
||||
{
|
||||
return pagevec_lookup_range_tag(pvec, mapping, index, (pgoff_t)-1, tag,
|
||||
nr_pages);
|
||||
return pagevec_lookup_range_tag(pvec, mapping, index, (pgoff_t)-1, tag);
|
||||
}
|
||||
|
||||
static inline void pagevec_init(struct pagevec *pvec, int cold)
|
||||
|
|
10
mm/filemap.c
10
mm/filemap.c
|
@ -451,12 +451,14 @@ static int __filemap_fdatawait_range(struct address_space *mapping,
|
|||
goto out;
|
||||
|
||||
pagevec_init(&pvec, 0);
|
||||
while ((index <= end) &&
|
||||
(nr_pages = pagevec_lookup_tag(&pvec, mapping, &index,
|
||||
PAGECACHE_TAG_WRITEBACK,
|
||||
min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1)) != 0) {
|
||||
while (index <= end) {
|
||||
unsigned i;
|
||||
|
||||
nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index,
|
||||
end, PAGECACHE_TAG_WRITEBACK);
|
||||
if (!nr_pages)
|
||||
break;
|
||||
|
||||
for (i = 0; i < nr_pages; i++) {
|
||||
struct page *page = pvec.pages[i];
|
||||
|
||||
|
|
|
@ -2229,8 +2229,8 @@ int write_cache_pages(struct address_space *mapping,
|
|||
while (!done && (index <= end)) {
|
||||
int i;
|
||||
|
||||
nr_pages = pagevec_lookup_tag(&pvec, mapping, &index, tag,
|
||||
min(end - index, (pgoff_t)PAGEVEC_SIZE-1) + 1);
|
||||
nr_pages = pagevec_lookup_range_tag(&pvec, mapping, &index, end,
|
||||
tag);
|
||||
if (nr_pages == 0)
|
||||
break;
|
||||
|
||||
|
|
|
@ -958,10 +958,10 @@ EXPORT_SYMBOL(pagevec_lookup);
|
|||
|
||||
unsigned pagevec_lookup_range_tag(struct pagevec *pvec,
|
||||
struct address_space *mapping, pgoff_t *index, pgoff_t end,
|
||||
int tag, unsigned nr_pages)
|
||||
int tag)
|
||||
{
|
||||
pvec->nr = find_get_pages_range_tag(mapping, index, end, tag,
|
||||
nr_pages, pvec->pages);
|
||||
PAGEVEC_SIZE, pvec->pages);
|
||||
return pagevec_count(pvec);
|
||||
}
|
||||
EXPORT_SYMBOL(pagevec_lookup_range_tag);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue