2012-11-20 22:13:10 +01:00
|
|
|
#ifndef __LINUX_COMPILER_H
|
|
|
|
|
#error "Please don't include <linux/compiler-clang.h> directly, include <linux/compiler.h> instead."
|
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|
|
/* Some compiler specific definitions are overwritten here
|
|
|
|
|
* for Clang compiler
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#ifdef uninitialized_var
|
|
|
|
|
#undef uninitialized_var
|
|
|
|
|
#define uninitialized_var(x) x = *(&(x))
|
|
|
|
|
#endif
|
2016-02-08 15:38:32 +01:00
|
|
|
|
|
|
|
|
/* same as gcc, this was present in clang-2.6 so we can assume it works
|
|
|
|
|
* with any version that can compile the kernel
|
|
|
|
|
*/
|
|
|
|
|
#define __UNIQUE_ID(prefix) __PASTE(__PASTE(__UNIQUE_ID_, prefix), __COUNTER__)
|
2017-06-16 12:52:57 -07:00
|
|
|
|
2018-04-20 14:55:52 -07:00
|
|
|
#undef __no_sanitize_address
|
|
|
|
|
#define __no_sanitize_address __attribute__((no_sanitize("address")))
|
|
|
|
|
|
2018-02-19 10:50:57 +00:00
|
|
|
/* Clang doesn't have a way to turn it off per-function, yet. */
|
|
|
|
|
#ifdef __noretpoline
|
|
|
|
|
#undef __noretpoline
|
|
|
|
|
#endif
|
2018-08-15 18:30:15 +02:00
|
|
|
|
2017-06-16 12:52:57 -07:00
|
|
|
#ifdef CONFIG_LTO_CLANG
|
|
|
|
|
#ifdef CONFIG_FTRACE_MCOUNT_RECORD
|
|
|
|
|
#define __norecordmcount \
|
|
|
|
|
__attribute__((__section__(".text..ftrace")))
|
|
|
|
|
#endif
|
2017-05-11 15:03:36 -07:00
|
|
|
|
|
|
|
|
#define __nocfi __attribute__((no_sanitize("cfi")))
|
2017-06-16 12:52:57 -07:00
|
|
|
#endif
|
2018-02-06 15:36:03 -08:00
|
|
|
|
|
|
|
|
/* all clang versions usable with the kernel support KASAN ABI version 5 */
|
|
|
|
|
#define KASAN_ABI_VERSION 5
|
|
|
|
|
|
|
|
|
|
/* emulate gcc's __SANITIZE_ADDRESS__ flag */
|
|
|
|
|
#if __has_feature(address_sanitizer)
|
|
|
|
|
#define __SANITIZE_ADDRESS__
|
|
|
|
|
#endif
|
2019-01-31 08:36:51 +01:00
|
|
|
|
compiler.h: enable builtin overflow checkers and add fallback code
commit f0907827a8a9152aedac2833ed1b674a7b2a44f2 upstream.
This adds wrappers for the __builtin overflow checkers present in gcc
5.1+ as well as fallback implementations for earlier compilers. It's not
that easy to implement the fully generic __builtin_X_overflow(T1 a, T2
b, T3 *d) in macros, so the fallback code assumes that T1, T2 and T3 are
the same. We obviously don't want the wrappers to have different
semantics depending on $GCC_VERSION, so we also insist on that even when
using the builtins.
There are a few problems with the 'a+b < a' idiom for checking for
overflow: For signed types, it relies on undefined behaviour and is
not actually complete (it doesn't check underflow;
e.g. INT_MIN+INT_MIN == 0 isn't caught). Due to type promotion it
is wrong for all types (signed and unsigned) narrower than
int. Similarly, when a and b does not have the same type, there are
subtle cases like
u32 a;
if (a + sizeof(foo) < a)
return -EOVERFLOW;
a += sizeof(foo);
where the test is always false on 64 bit platforms. Add to that that it
is not always possible to determine the types involved at a glance.
The new overflow.h is somewhat bulky, but that's mostly a result of
trying to be type-generic, complete (e.g. catching not only overflow
but also signed underflow) and not relying on undefined behaviour.
Linus is of course right [1] that for unsigned subtraction a-b, the
right way to check for overflow (underflow) is "b > a" and not
"__builtin_sub_overflow(a, b, &d)", but that's just one out of six cases
covered here, and included mostly for completeness.
So is it worth it? I think it is, if nothing else for the documentation
value of seeing
if (check_add_overflow(a, b, &d))
return -EGOAWAY;
do_stuff_with(d);
instead of the open-coded (and possibly wrong and/or incomplete and/or
UBsan-tickling)
if (a+b < a)
return -EGOAWAY;
do_stuff_with(a+b);
While gcc does recognize the 'a+b < a' idiom for testing unsigned add
overflow, it doesn't do nearly as good for unsigned multiplication
(there's also no single well-established idiom). So using
check_mul_overflow in kcalloc and friends may also make gcc generate
slightly better code.
[1] https://lkml.org/lkml/2015/11/2/658
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-05-08 00:36:27 +02:00
|
|
|
/*
|
|
|
|
|
* Not all versions of clang implement the the type-generic versions
|
|
|
|
|
* of the builtin overflow checkers. Fortunately, clang implements
|
|
|
|
|
* __has_builtin allowing us to avoid awkward version
|
|
|
|
|
* checks. Unfortunately, we don't know which version of gcc clang
|
|
|
|
|
* pretends to be, so the macro may or may not be defined.
|
|
|
|
|
*/
|
|
|
|
|
#undef COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW
|
|
|
|
|
#if __has_builtin(__builtin_mul_overflow) && \
|
|
|
|
|
__has_builtin(__builtin_add_overflow) && \
|
|
|
|
|
__has_builtin(__builtin_sub_overflow)
|
|
|
|
|
#define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1
|
|
|
|
|
#endif
|
